Change in ovirt-engine-sdk-ruby[master]: Write correctly lists of enum values

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Sep 21 15:00:45 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: Write correctly lists of enum values
......................................................................


Write correctly lists of enum values

Currently the SDK doesn't write correctly lists of enum values, because
it tries to end the list calling the "end_element" method of the
"XmlWriter" class, which doesn't exist, the correct name is "write_end".
This is a bug in the code generator, fixed by this patch.

Change-Id: I87577ec88be3dcfe21d879fb4393f677a74511e7
Bug-Url: https://bugzilla.redhat.com/1378066
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java
M sdk/spec/vm_writer_spec.rb
2 files changed, 33 insertions(+), 1 deletion(-)

Approvals:
  Boris Odnopozov: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64245
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87577ec88be3dcfe21d879fb4393f677a74511e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Boris Odnopozov <bodnopoz at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list