Change in ovirt-engine[master]: aaa: Internal server error once automatically logged out

mperina at redhat.com mperina at redhat.com
Thu Sep 22 07:39:33 UTC 2016


Martin Peřina has submitted this change and it was merged.

Change subject: aaa: Internal server error once automatically logged out
......................................................................


aaa: Internal server error once automatically logged out

Session expiration on webadmin or userportal
after redirecting to sso causes the session
attributes to be lost resulting in a NPE.

Passing app_url to sso and receiving it back
from sso instead of saving app_url in session
resolves the issue of session expiration.

Change-Id: I44e423d52b5058add54d4ee69e09e1c54f363712
Bug-Url: https://bugzilla.redhat.com/1376003
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLoginServlet.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
7 files changed, 35 insertions(+), 6 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Ravi Nori: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64219
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44e423d52b5058add54d4ee69e09e1c54f363712
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list