Change in ovirt-engine[master]: webadmin: Null check before model cleanup

tnisan at redhat.com tnisan at redhat.com
Mon Sep 26 12:25:39 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Null check before model cleanup
......................................................................


webadmin: Null check before model cleanup

Patch gerrit.ovirt.org/63708 introduced improved model cleanup yet in
cases where the model is already null due to a missing null check a UI
exception will be thrown (for instance when closing a dialog with ESC)

Bug-Url: https://bugzilla.redhat.com/1379312
Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/64458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list