Change in ovirt-engine[master]: webadmin: Don't clean upload model on dialog closing.

tnisan at redhat.com tnisan at redhat.com
Tue Sep 27 12:29:53 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Don't clean upload model on dialog closing.
......................................................................


webadmin: Don't clean upload model on dialog closing.

Patch I363d06219af83bd21e6384840bf9a969331a9959 introduced a better
handling of model objects, which makes the dialogs in the system to
clean up their related models.

In UploadImageModel, the model is still alive as it is used to upload
the user's file- so it shouldn't be cleaned while the upload dialog is
closed.

This patch removes the cleaning of the model in UploadImagePopupView.

Change-Id: I91b40d5a78d190c16d78e950c892638ea839580e
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Amit Aviram: Verified



-- 
To view, visit https://gerrit.ovirt.org/64459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I91b40d5a78d190c16d78e950c892638ea839580e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list