Change in ovirt-engine[master]: core: Remove TestAuditLoggableBase

amureini at redhat.com amureini at redhat.com
Wed Sep 28 22:25:59 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove TestAuditLoggableBase
......................................................................


core: Remove TestAuditLoggableBase

Used mockito to @Spy AuditLoggableBase's DAOs and initialized the
behavior in the @Before method, as per JUnit's best practices.

Change-Id: I7a94668862bb56b29885a9a275320f1348f59be9
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
1 file changed, 54 insertions(+), 83 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64599
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a94668862bb56b29885a9a275320f1348f59be9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list