Change in ovirt-engine[master]: core: Make OvfUpdateProcessHelper a CDI component

tnisan at redhat.com tnisan at redhat.com
Thu Sep 29 09:42:17 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Make OvfUpdateProcessHelper a CDI component
......................................................................


core: Make OvfUpdateProcessHelper a CDI component

This patch makes OvfUpdateProcessHelper a CDI component thus enabling it
to be injected, another benefit is removing VmDeviceUtils that is passing
through the constructor

Change-Id: I6818246e294a293c34ff5b957f71c0fad9cb6245
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfUpdateProcessHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
5 files changed, 60 insertions(+), 70 deletions(-)

Approvals:
  Tal Nisan: Verified; Passed CI tests
  Martin Betak: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, approved
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/64523
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6818246e294a293c34ff5b957f71c0fad9cb6245
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list