Change in ovirt-engine[ovirt-engine-4.1]: CopyImageGroup/CloneImageGroupVolumesStructure - volume format

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: CopyImageGroup/CloneImageGroupVolumesStructure - volume format
......................................................................


CopyImageGroup/CloneImageGroupVolumesStructure - volume format

CopyImageGroupCommand generates a destination format for the target disk
when performing a disk copy. This format is by the command when copying
a disk with snapshot collapse by passing it to the CopyImage vdsm verb
or when executing the CopyImageGroupWithData command (spdm flow).

The CopyImageGroupWithData command used that format for creating a
collapsed volume, but it passed it to CloneImageGroupVolumesStructure
which is used when cloning the image structure without performing
collapse.

This patch changes CopyImageGroupWithData and
CloneImageGroupVolumesStructure to not use the generated format when
creating the target image without collapse, but use the original volume
format.

Change-Id: Ie70f847a069a80e3c8e5bc45223da51ef957ed30
Bug-Url: https://bugzilla.redhat.com/1437383
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneImageGroupVolumesStructureCommandParameters.java
3 files changed, 3 insertions(+), 16 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Maor Lipchuk: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/74807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie70f847a069a80e3c8e5bc45223da51ef957ed30
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>