Change in ovirt-engine[master]: webadmin, userportal: Fix GWT compile warning in draft mode

Code Review gerrit at ovirt.org
Tue Apr 4 15:46:55 UTC 2017


>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: Fix GWT compile warning in draft mode
......................................................................


webadmin,userportal: Fix GWT compile warning in draft mode

Disable putting JavaScript globals into namespaces as it can
produce bugs, especially when using GWT code splitting feature.

https://groups.google.com/forum/#!topic/google-web-toolkit/y9HNzW0qsWg

Change-Id: Ibfb2a05e7a36e846b4581f9c7ecd09dcea04e79e
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/pom.xml
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/74984
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfb2a05e7a36e846b4581f9c7ecd09dcea04e79e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list