Change in ovirt-engine[master]: core: Fix LunDao#removeAll

Code Review gerrit at ovirt.org
Thu Apr 6 14:07:02 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Fix LunDao#removeAll
......................................................................


core: Fix LunDao#removeAll

The removeAll method uses the procedure defined by
setProcedureNameForRemove.
Since it was not called, the removeAll method tried to use the
standard method by naming convention ("deleteluns"), which, of
course, does not exist.

This patch adds the missing call to setProcedureNameForRemove in
LunDaoImpl, a test in LunDaoTest to assure the fix is correct, and
some fixture data to use in this test.

Change-Id: I7bb32324b2412f03d09277c91fd7dd9f9b32729e
Bug-Url: https://bugzilla.redhat.com/1439692
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/LunDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
4 files changed, 35 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/75302
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bb32324b2412f03d09277c91fd7dd9f9b32729e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list