Change in ovirt-engine[master]: core: LunDaoTest to extend BaseGenericDaoTestCase

Code Review gerrit at ovirt.org
Thu Apr 6 14:07:02 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: LunDaoTest to extend BaseGenericDaoTestCase
......................................................................


core: LunDaoTest to extend BaseGenericDaoTestCase

Reuse the tests from BaseGenericDaoTestCase instead of the copy-paste
implementations that currently exist in the test.

Change-Id: I4b25996019b6cc4372a86babd6effd72cffe825f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/LunDaoTest.java
1 file changed, 24 insertions(+), 69 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/75301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b25996019b6cc4372a86babd6effd72cffe825f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list