Change in ovirt-engine[master]: webadmin: Use Collection in ExistingPoolModelBehavior#postDa...

Code Review gerrit at ovirt.org
Thu Apr 6 19:05:11 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Use Collection in ExistingPoolModelBehavior#postDataCenterWithClusterSelectedItemChanged
......................................................................


webadmin: Use Collection in ExistingPoolModelBehavior#postDataCenterWithClusterSelectedItemChanged

Use a Collection instead of an Iterable to store the value returned
from getModel().getDataCenterWithClustersList().getItems() (which,
indeed, returns a Collection anyway).

While this method doesn't need any specific method from Collection,
performing this change is needed in order to set up the subsequent
changes to the Linq class.

Change-Id: Ic1a85101e4604945cb4c6ff002789bc3a6f5ea43
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/75163
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1a85101e4604945cb4c6ff002789bc3a6f5ea43
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list