Change in ovirt-engine[master]: webadmin: Inline Linq#findHostByIdFromIdList
Code Review
gerrit at ovirt.org
Thu Apr 6 19:05:13 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Inline Linq#findHostByIdFromIdList
......................................................................
webadmin: Inline Linq#findHostByIdFromIdList
Linq#findHostByIdFromIdList is only used in one place,
ModelWithPinnedHost, and as such shouldn't belong in a
general-purpose class like Linq.
Since Java 8's streams provide an elegant, single-statement, way of
achieving the same functionality, this patch removes that method and
inlines its functionality directly where its needed.
As an added bonus, this patch consolidates the filtering and the
sorting of the resulting list, generating a slight performance
improvement.
Change-Id: Ied62d6a2a0a361313e41e5909793ae35a55d1646
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/ModelWithPinnedHost.java
2 files changed, 5 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/75190
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied62d6a2a0a361313e41e5909793ae35a55d1646
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list