Change in ovirt-engine[master]: webadmin: Remove Linq#findAllVDSByPmEnabled
Code Review
gerrit at ovirt.org
Thu Apr 6 19:05:14 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Remove Linq#findAllVDSByPmEnabled
......................................................................
webadmin: Remove Linq#findAllVDSByPmEnabled
Linq#findAllVDSByPmEnabled is only used in one place, HostListModel,
and as such should probably not be part of a general-purpose class
like Linq.
This patch removes that methods and reimplements its logic directly
in HostListModel. As a side bonus, the new implementation uses the
fail-fast allMatch to return false immediately when the first host
that doesn't have power management enabled is found instead of
continuing to iterate over the entire list of hosts.
Change-Id: If6c459331ff21e29f136851cf4f268aad228e4e0
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
2 files changed, 1 insertion(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/75177
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6c459331ff21e29f136851cf4f268aad228e4e0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list