Change in ovirt-engine[master]: webadmin: Reimplement AbstractDiskModel#updateStorageDomains

Code Review gerrit at ovirt.org
Thu Apr 6 19:05:14 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Reimplement AbstractDiskModel#updateStorageDomains
......................................................................


webadmin: Reimplement AbstractDiskModel#updateStorageDomains

This patch reimplements updateStorageDomains so that the list of
storage domains is only traversed once, instead of up to four times
(for regular images - once to get the data domain, once to get the
master domain(s), once to filter only the active domain and then
again to sort the result).

As a result, the methods filterStorageDomainsByStorageDomainType and
filterStorageDomainsByStorageStatus of the Linq class remained
unused, and were subsequently removed.

Change-Id: I42d623c9a6b68db17e3b65c9a2ffc9403c39d426
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
2 files changed, 15 insertions(+), 32 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/75189
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42d623c9a6b68db17e3b65c9a2ffc9403c39d426
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list