Change in ovirt-engine[master]: webadmin: Inline Linq#findAllStorageDomainsBySharedStatus
Code Review
gerrit at ovirt.org
Thu Apr 6 19:05:15 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Inline Linq#findAllStorageDomainsBySharedStatus
......................................................................
webadmin: Inline Linq#findAllStorageDomainsBySharedStatus
Linq#findAllStorageDomainsBySharedStatus is only used in one place,
StorageListModel, on a list that is verified to have a single item in
it. As such, it's a poor fit for a general-purpose class like Linq.
This patch removes the aforementioned method and rewrites its logic
in a simple and straight forward way directly in StorageListModel.
Change-Id: I5787aa990e66584d2a125ff7a0c9f40da4a6fcf8
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
2 files changed, 1 insertion(+), 12 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/75178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5787aa990e66584d2a125ff7a0c9f40da4a6fcf8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list