Change in ovirt-engine[master]: core: Migrate VideoDeviceSettings to CDI
Code Review
gerrit at ovirt.org
Sat Apr 8 18:02:27 UTC 2017
>From Martin Betak <mbetak at redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: core: Migrate VideoDeviceSettings to CDI
......................................................................
core: Migrate VideoDeviceSettings to CDI
Replace static utility class with a CDI singleton. This is done mainly to
enable the migration of ClusterUtils to CDI in subsequent patch.
Change-Id: I880131fa9b6e6b96f0cb658c72b05179bd7ed4c9
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/LegacyVideoSettings.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VgamemVideoSettings.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VideoDeviceSettings.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmOverheadCalculatorImpl.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java
6 files changed, 137 insertions(+), 90 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Martin Betak: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I880131fa9b6e6b96f0cb658c72b05179bd7ed4c9
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list