Change in ovirt-engine[master]: core, webadmin: HotUnplugMemoryCommand added

[Code Review]

>From Martin Betak <mbetak at redhat.com>:

Martin Betak has submitted this change and it was merged.

Change subject: core, webadmin: HotUnplugMemoryCommand added
......................................................................


core, webadmin: HotUnplugMemoryCommand added

Command to perform memory hot unplug. Memory device to hot unplug is
identified by VmDeviceId. If the VM is UP and there is a memory device
of that size, VDSM memory hot unplug is called. If the call succeeds and
it wouldn't end up being negative, memory of VM is decreased.
VM#getMinAllocatedMem is also decreased if necessary.

HotUnplugMemoryCommand doesn't use UpdateVmCommand because using it
would either (based on value of
VmManagementParametersBase#applyChangesLater) immediately apply changes
in next run configuration or discard changes planed in next run
configuration.

The command is intentionally non-transactional. Races between writes to
snapshots and vm_static are not considered a problem.

Change-Id: I8e9d09bd01ef357c203ae32cba66f9c59115aeee
Bug-Url: https://bugzilla.redhat.com/1228543
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnplugMemoryCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HotUnplugMemoryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
16 files changed, 326 insertions(+), 28 deletions(-)

Approvals:
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/73082
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e9d09bd01ef357c203ae32cba66f9c59115aeee
Gerrit-PatchSet: 42
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>