Change in ovirt-engine[master]: core: FenceVolumeJob - avoiding growing number of db records

[Code Review]

>From Liron Aravot <laravot at redhat.com>:

Liron Aravot has submitted this change and it was merged.

Change subject: core: FenceVolumeJob - avoiding growing number of db records
......................................................................


core: FenceVolumeJob - avoiding growing number of db records

FenceVolumeJob is executed in order to fence operations that were
submitted and are supposed to be performed on the volume.
In case of failure to fence an operation, the engine may attempt to
fence it again - when the fencing fails constantly the number of
commands will grow till the flow ends. As we store a record for each
command in the commands table that's something should be prevented.
The engine uses the command record just for polling (to avoid executing
another fence operation before the previous one ended) and not for
determining if the fencing succeeded (it polls the entity to verify
that), therefore we are fine with deleting the command entity after the
execution ends.

Change-Id: I62659c3840ce4bc46f7846751d45b779f3606279
Bug-Url: https://bugzilla.redhat.com/1440549
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/FenceVolumeJobCommand.java
2 files changed, 24 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Moti Asayag: Looks good to me, approved
  Liron Aravot: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/75390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62659c3840ce4bc46f7846751d45b779f3606279
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>