Change in ovirt-engine[master]: webadmin: Remove Linq#concatUnsafe

Code Review gerrit at ovirt.org
Wed Apr 12 11:18:31 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Remove Linq#concatUnsafe
......................................................................


webadmin: Remove Linq#concatUnsafe

This patch replaces the usage of Linq#concatUnsafe in GuidePopupView
with a better inline implementation using Java 8 streams which avoids
the need to create a temporary concatinated list.

As a result of this improvement, Linq#concatUnsafe is no longer used,
and can safely be removed.

Change-Id: I0340a9a0ca6a5ec7f88c488b982f7dae93944ef6
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java
2 files changed, 6 insertions(+), 20 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/75457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0340a9a0ca6a5ec7f88c488b982f7dae93944ef6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list