Change in ovirt-engine[ovirt-engine-4.1]: core: Set qcow compat for floating QCOW volumes.

Code Review gerrit at ovirt.org
Thu Apr 13 14:15:17 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Set qcow compat for floating QCOW volumes.
......................................................................


core: Set qcow compat for floating QCOW volumes.

Unregistered disks should be set with QCOW compat returned from the
storage domain.
Addition to this fix are the following changes:
1) use the register with multiple action to prevent a
use case which VDSM will be non responsive.
2) Use non transactive in register disk so VDSM call will not hang the
transaction.
3) Adding an audit log indicating the initial of register disk.

Change-Id: I45f10a82fdf05737c952a6ffdbf0aaab48de9ff4
Bug-Url: https://bugzilla.redhat.com/1432493
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RegisterDiskModel.java
5 files changed, 99 insertions(+), 18 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Verified
  Liron Aravot: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/75514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I45f10a82fdf05737c952a6ffdbf0aaab48de9ff4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list