Change in ovirt-engine[master]: engine: remove injection into ALB in DisplayNetworkClusterHe...

Code Review gerrit at ovirt.org
Wed Apr 19 08:24:47 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: remove injection into ALB in DisplayNetworkClusterHelper
......................................................................


engine: remove injection into ALB in DisplayNetworkClusterHelper

Remove injection into AuditLogableBase in DisplayNetworkClusterHelper
and add test coverage to the class.

Change-Id: I6533973e45576c81d207723362d936976e4f653f
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/helper/DisplayNetworkClusterHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/helper/DisplayNetworkClusterHelperTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
5 files changed, 49 insertions(+), 19 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/75319
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6533973e45576c81d207723362d936976e4f653f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list