Change in ovirt-engine[master]: core: Initialize LUN ids once in AddSANStorageDomainParameters
Code Review
gerrit at ovirt.org
Wed Apr 19 12:56:26 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Initialize LUN ids once in AddSANStorageDomainParameters
......................................................................
core: Initialize LUN ids once in AddSANStorageDomainParameters
The getter of LUN ids creates a new ArrayList instance every time it's
invoked, instead it's better to just initialize the parameter
Change-Id: I8c30f7d004302845d2c336efda9788bac84ee148
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddSANStorageDomainParameters.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75631
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c30f7d004302845d2c336efda9788bac84ee148
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list