Change in ovirt-engine[master]: core: Remove leftover SPICE channel on RunVM

Code Review gerrit at ovirt.org
Wed Apr 19 14:21:14 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: Remove leftover SPICE channel on RunVM
......................................................................


core: Remove leftover SPICE channel on RunVM

After run of VM with SPICE graphics device the SPICEVMC channel remained in the
vm_device table even after the VM has been long recofigured to not use SPICE.

Since we don't want to remove this device prematurely, we extended the
pre-vm-run device handling to also remove stray channels in the RunVmCommand.

Change-Id: Ie2159a3ba247cabe2002dd9e9043126b65b3dd42
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430688
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Martin Betak: Verified
  Sharon Gratch: Looks good to me, but someone else must approve
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/75315
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2159a3ba247cabe2002dd9e9043126b65b3dd42
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list