Change in ovirt-engine[master]: webadmin: Unplugging state of hot mem unplug button

[Code Review]

>From Tomas Jelinek <tjelinek at redhat.com>:

Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: Unplugging state of hot mem unplug button
......................................................................


webadmin: Unplugging state of hot mem unplug button

When memory hot unplug action is confirmed the "Hot unplug" button is
disabled and relabeled to "Unplugging ..." for 15 seconds. This informs
user that the action is in progress and prevents him from re-invoking
it. "Hot unplug" button is disabled if corresponding VM is not in state
'UP' or if memory hot unplug is disabled by
ConfigValues#HotUnplugMemorySupported.

* New entity VmDeviceFeEntity introduced to be able to hold frontend
  specific state of VmDevice - #isBeingUnplugged. It inherits from
  VmDevice.
* VmDevicesListModel and related classes use VmDeviceFeEntity instead of
  VmDevice.
* backend part: VmDevice has copy constructor and inheritance friendly
  toString() method.

Change-Id: I78a0eba2dd80a01f2f5f695b4ea1034b2b9e40b4
Bug-Url: https://bugzilla.redhat.com/1228543
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/VmDeviceGeneralTypeColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/HotUnplugCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/HotUnplugColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDevicesListModelTable.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/utils/ExpiringSet.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDeviceFeEntity.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDevicesListModel.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineVmDevicePresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineVmDevicesView.java
17 files changed, 288 insertions(+), 76 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/72638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78a0eba2dd80a01f2f5f695b4ea1034b2b9e40b4
Gerrit-PatchSet: 61
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>