Change in ovirt-engine[master]: core: ReduceSANStorageDomainDevicesCommand validation order

Code Review gerrit at ovirt.org
Sun Apr 23 20:11:42 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: ReduceSANStorageDomainDevicesCommand validation order
......................................................................


core: ReduceSANStorageDomainDevicesCommand validation order

Change the order of ReduceSANStorageDomainDevicesCommand#validate()
so that the domain's storage type is validated before its version.
This makes sense since a user could potentially handle the domain's
version (by upgrading the DC), but can't change the underlying
storage type.

Change-Id: I3d395a8994705ed401f52827a39c648a15ca7744
Bug-Url: https://bugzilla.redhat.com/1443920
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/75683
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d395a8994705ed401f52827a39c648a15ca7744
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list