Change in ovirt-engine[master]: webadmin: Remove Converter interface
Code Review
gerrit at ovirt.org
Sun Apr 23 20:39:31 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Remove Converter interface
......................................................................
webadmin: Remove Converter interface
The Converter interface is basically a Function. This patch removes
that interface and replaces all its usages with a standard Java 8
Function.
This both saves us from maintaining another interface and gives us all
the power behind Functions for free.
Change-Id: Ibdad15f45df642d64139c0866edd4f5fc5ecb3b6
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java
D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Converter.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
5 files changed, 28 insertions(+), 30 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75764
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdad15f45df642d64139c0866edd4f5fc5ecb3b6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list