Change in ovirt-engine[master]: webadmin: Further generalize Converter

Code Review gerrit at ovirt.org
Sun Apr 23 20:39:31 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Further generalize Converter
......................................................................


webadmin: Further generalize Converter

This patch makes Converter's source type generic too in order to save
boiler-plate casts and to better take advantage of Java 8's type
inference.

Change-Id: Ia5ffc193cb8cadeb209d8d46fb520bc1a62511fb
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Converter.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
4 files changed, 39 insertions(+), 41 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/75758
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5ffc193cb8cadeb209d8d46fb520bc1a62511fb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list