Change in ovirt-engine[master]: core: Fix NPE on floating disk creation through REST

Code Review gerrit at ovirt.org
Tue Apr 25 09:49:09 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Fix NPE on floating disk creation through REST
......................................................................


core: Fix NPE on floating disk creation through REST

Commit d9a7c1c moved the read only property of a disk from the disk entity
to the relation between a disk and a VM where it belongs, since the
property was moved, validating whether a read only property is compatible
should be done only in case of adding a disk that is connected to a VM.

Change-Id: I5257e7ab9c048b31d134a0f09fbeceed7d596061
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Benny Zlotnik: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/75987
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5257e7ab9c048b31d134a0f09fbeceed7d596061
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list