Change in ovirt-log-collector[master]: inventory - move storage create tablet to sql file
Code Review
gerrit at ovirt.org
Thu Apr 27 06:38:18 UTC 2017
>From Sandro Bonazzola <sbonazzo at redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: inventory - move storage create tablet to sql file
......................................................................
inventory - move storage create tablet to sql file
Splitting the logic helps the code readability.
Change-Id: I51397016d18293dc37c9161f5f6d67709f9cdc30
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M src/inventory_report/produceReport.sh
M src/inventory_report/sqls/cleanup.sql
A src/inventory_report/sqls/storage_create_related_lookup_tables.sql
3 files changed, 34 insertions(+), 22 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76018
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51397016d18293dc37c9161f5f6d67709f9cdc30
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael at rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list