Change in ovirt-engine[master]: core: cleanup in SetVmStatus

[Code Review]

>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: cleanup in SetVmStatus
......................................................................


core: cleanup in SetVmStatus

1. This command is called internally from just a few places so
we can remove the validation of the parameters at the beginning
of the execute method.

2. This command is not used for setting the VM status to Unknown
thus the code for this specific case is removed.

3. This command is only used to set the VM status to Down or
ImageLocked, in both statuses the VM is not running, thus its
execute method can be simplified.

Change-Id: I724544f8063e04a7a5405a8e5cc25abea87c3b42
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java
1 file changed, 5 insertions(+), 21 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/76033
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I724544f8063e04a7a5405a8e5cc25abea87c3b42
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>