Change in ovirt-engine[master]: webadmin: handle VmDynamic.fqdn==null in SubTabNetworkVmView
Code Review
gerrit at ovirt.org
Thu Apr 27 12:30:34 UTC 2017
>From Tomas Jelinek <tjelinek at redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: handle VmDynamic.fqdn==null in SubTabNetworkVmView
......................................................................
webadmin: handle VmDynamic.fqdn==null in SubTabNetworkVmView
In case VmDynamic.fqdn is set to null value, there is a "is null"
exception thrown by SafeHtmlString while trying to create the fqdn
tooltip in fqdnColumn.getTooltip() method.
Avoiding that by passing an empty str instead of a null value.
Change-Id: Ib27f4090bd51b15f48d37cf1dfdecbde2b5f2811
Bug-Url: https://bugzilla.redhat.com/1442697
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/76133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib27f4090bd51b15f48d37cf1dfdecbde2b5f2811
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list