Change in ovirt-log-collector[master]: do not require execution from current dir + init variables o...
Code Review
gerrit at ovirt.org
Fri Apr 28 14:26:36 UTC 2017
>From Douglas Schilling Landgraf <dougsland at redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: do not require execution from current dir + init variables on 1 place
......................................................................
do not require execution from current dir + init variables on 1 place
• uninitialized variables, inlined function 'initDbVariables'
• script needs not to be executed from current directory, thus 'sqls'
directory needs to be referenced in relations to produceReport script
Change-Id: Ibb424687aee48708203668af9234eafd620d5d05
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M src/inventory_report/produceReport.sh
1 file changed, 11 insertions(+), 16 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76063
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb424687aee48708203668af9234eafd620d5d05
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list