Change in ovirt-engine[master]: core: Lock a prestarted VM from pool when attaching to user

[Code Review]

>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: Lock a prestarted VM from pool when attaching to user
......................................................................


core: Lock a prestarted VM from pool when attaching to user

When a prestarted VM from pool is being attached to user, the VM lock on
it is added to the context, but not actually taken. Because of this, a
race condition may happen when one and the same prestarted VM is given
to several users.

Change-Id: I8ffe5ab7675ef76ed0f39ac8ca2d6e7ff8da30a2
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
1 file changed, 18 insertions(+), 28 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/75833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ffe5ab7675ef76ed0f39ac8ca2d6e7ff8da30a2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>