Change in ovirt-engine[master]: core: Refactor AttachUserToVmFromPoolAndRunCommand.validate()

Code Review gerrit at ovirt.org
Sun Apr 30 13:08:00 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: Refactor AttachUserToVmFromPoolAndRunCommand.validate()
......................................................................


core: Refactor AttachUserToVmFromPoolAndRunCommand.validate()

* Do not call setActionMessageParameters() directly;
* Use failValidation() method;
* Make detachUserFromVmFromPool() method private.

Change-Id: Ie15319f728015f313a2910aceff3b30b0e6ab07f
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
1 file changed, 15 insertions(+), 28 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/76167
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie15319f728015f313a2910aceff3b30b0e6ab07f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list