Change in ovirt-engine[ovirt-engine-4.1]: backend: remove character restrictions from network names

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79990 )

Change subject: backend: remove character restrictions from network names
......................................................................


backend: remove character restrictions from network names

Currently, oVirt limits the names of its networks to 15
alphanumeric characters. This limitation dates back to
the ages where all networks were VM network, all were
implemented by a Linux bridge, and the same name was
used to identify the network and the Linux bridge
implementing it on each host.

That has to change. 15 characters are not enough for
humans; spaces, and other special characters are
visually useful, and non-English speaking users
would love to use their native alphabet in network names.

For this reason network names are allowed to consist of 256 Unicode
characters. If a Linux bridge is created, the name is created
from the network name, if it is suitable, or from the network's uuid.

(cherry-picked from commit 0cee2277bbbf176a6ed0f56e40a04ff56b86f1f5)

Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1476823
Change-Id: Idadf272959ae10afc1de7ed6ce6daed70b78b73d
Signed-off-by: Leon Goldberg <lgoldber at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/bll/network/NetworkVdsmNameMapper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetCapabilitiesVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/04_01_0840_add_vdsm_name_to_network.sql
16 files changed, 116 insertions(+), 20 deletions(-)

Approvals:
  Dominik Holler: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Leon Goldberg: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idadf272959ae10afc1de7ed6ce6daed70b78b73d
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>