Change in ovirt-engine[master]: core: better alignment with ovf specification for disks

Code Review gerrit at ovirt.org
Wed Aug 2 13:07:57 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79585 )

Change subject: core: better alignment with ovf specification for disks
......................................................................


core: better alignment with ovf specification for disks

The "File" elements in the References section are designed to enable tools
to verify the integrity of the OVF package (OVA). They are supposed to be
minimal. However, we abuse them by adding additional information about the
disk in these elements.

So in order to be better aligned with the specification, this patch changes
the OVF reader to consume that data from the "Disk" elements inside the
"DiskSection" part, without breaking backward compatibility.

Change-Id: Idcbc86decd53d2495b5f8ece78acf52cbef60bc4
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
2 files changed, 60 insertions(+), 32 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/79585
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idcbc86decd53d2495b5f8ece78acf52cbef60bc4
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list