Change in ovirt-engine[master]: core: novnc import of css and js fixed

Code Review gerrit at ovirt.org
Thu Aug 3 13:21:17 UTC 2017


>From Tomas Jelinek <tjelinek at redhat.com>:

Tomas Jelinek has submitted this change and it was merged. ( https://gerrit.ovirt.org/80059 )

Change subject: core: novnc import of css and js fixed
......................................................................


core: novnc import of css and js fixed

novnc-main.jsp contained hardcoded dependencies to patternfly css and
js, that stopped working since patch
https://gerrit.ovirt.org/#/c/61716.

<link> and <script> including tags replaced by jsp tags from "obrand"
library.

Change-Id: I05ee87fdf18ec6a4239927ea84db785021225557
Bug-Url: https://bugzilla.redhat.com/1475845
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/services/src/main/webapp/novnc-main.jsp
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80059
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05ee87fdf18ec6a4239927ea84db785021225557
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list