Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Use default grid item comparator

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80127 )

Change subject: webadmin: Use default grid item comparator
......................................................................


webadmin: Use default grid item comparator

If a grid has no explicit column sorting applied by the user
(which is the initial state of all grids), use a default item
comparator with following logic:

- first, try to compare by name (lexo-numeric) if the item is
  assignable to Nameable interface (this covers most, but not
  all, business entities), or treat it as null

- otherwise (for items still considered equal by above rule),
  try to compare by queryable ID if the item is assignable to
  Queryable interface (this should cover the rest of entities),
  or treat it as null

- finally, put "null" items at the end (nulls last strategy)

Above comparator logic is in-line with the general UI design
of having "Name" column with clickable links leading to detail
views for each main grid.

Above comparator is not applied if a grid has been explicitly
sorted by the user (by clicking the given column header).

Change-Id: I4711af76410a16354c38c083130be1c2e033306f
Bug-Url: https://bugzilla.redhat.com/1445235
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java
3 files changed, 74 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/80127
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4711af76410a16354c38c083130be1c2e033306f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>