Change in ovirt-engine[master]: core: Remove other DAOs from DiskImageDynamicDaoTest

Code Review gerrit at ovirt.org
Tue Aug 8 17:10:44 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80244 )

Change subject: core: Remove other DAOs from DiskImageDynamicDaoTest
......................................................................


core: Remove other DAOs from DiskImageDynamicDaoTest

DiskImageDynamicDaoTest is supposed to test DiskImageDynamicDao, not
other DAOs.
This patch removes the test of other DAOs from this class, and leaves
them to be tests in their own classes.

Change-Id: I9807684bd998620bc45b95829f15e271811d9a3c
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java
1 file changed, 4 insertions(+), 28 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/80244
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9807684bd998620bc45b95829f15e271811d9a3c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list