Change in ovirt-engine[master]: core: Hard code session IDs in tests

[Code Review]

>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79757 )

Change subject: core: Hard code session IDs in tests
......................................................................


core: Hard code session IDs in tests

This patch adds engine session IDs to the fixtures file so that the
DAO tests can use them.
This removes the dependency that QuotaDaoTest and PermissionDaoTest
currently have on EngineSessionDao, which in theory is unrelated to
them and can cause false positives in case there's a problem with it.
In other words, this patch improves the isolation of the DAO tests.

Another improvement gained here is the removal of two DAO calls from
each of these tests' setup() methods, which should improve their
speed.

Change-Id: Ie85830335420f68e4b60ad936359af0213dc4c6f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
4 files changed, 27 insertions(+), 46 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/79757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie85830335420f68e4b60ad936359af0213dc4c6f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>