Change in ovirt-engine[master]: core: Fix VdsDynamicDao#testCheckIfExistsHostWithStatusInClu...

Code Review gerrit at ovirt.org
Tue Aug 8 17:10:48 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80281 )

Change subject: core: Fix VdsDynamicDao#testCheckIfExistsHostWithStatusInCluster
......................................................................


core: Fix VdsDynamicDao#testCheckIfExistsHostWithStatusInCluster

Fix VdsDynamicDao#testCheckIfExistsHostWithStatusInCluster to rely
only on the predefined data provided in the fixtures instead of
having to use other DAOs.

Besides improving the test's stability, as a neat side bonus the test
is made much faster since it doesn't have to perform any updates
anymore.

Change-Id: I981de64bc51e0a398bc193e2b1dce4b7445e2d7e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDaoTest.java
1 file changed, 4 insertions(+), 13 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/80281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I981de64bc51e0a398bc193e2b1dce4b7445e2d7e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list