Change in ovirt-engine[master]: core: Clean up VmDynamicDaoTest#testSave

Code Review gerrit at ovirt.org
Tue Aug 8 17:10:49 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80299 )

Change subject: core: Clean up VmDynamicDaoTest#testSave
......................................................................


core: Clean up VmDynamicDaoTest#testSave

Clean up the testSave() method so it doesn't have to rely on
VmDyanmicDao#remove(Guid).

This patch improves the test's resilience as well as its speed.

Change-Id: If9940efc8813a5229732cf98df262890db360aef
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDaoTest.java
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/80299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9940efc8813a5229732cf98df262890db360aef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list