Change in ovirt-engine[master]: core: StorageServerConnectionDaoTest to extend BaseGenericDa...

[Code Review]

>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80314 )

Change subject: core: StorageServerConnectionDaoTest to extend BaseGenericDaoTestCase
......................................................................


core: StorageServerConnectionDaoTest to extend BaseGenericDaoTestCase

Make StorageServerConnectionDaoTest extend BaseGenericDaoTestCase
instead of reimplementing its logic.

Besides cleaning up the code, this moves also increases coverage by
running the base test case's tests and arguably improves the test's
performance by consolidating test multiple test scenarios into single
cases.

Change-Id: If94b58c60ce256ce58d83958845c1a7ee6568260
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDaoTest.java
1 file changed, 36 insertions(+), 120 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/80314
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If94b58c60ce256ce58d83958845c1a7ee6568260
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>