Change in ovirt-engine[ovirt-engine-4.1]: backend: Temporarily restrict network names.
Code Review
gerrit at ovirt.org
Wed Aug 9 07:41:19 UTC 2017
>From Oved Ourfali <oourfali at redhat.com>:
Oved Ourfali has submitted this change and it was merged. ( https://gerrit.ovirt.org/80389 )
Change subject: backend: Temporarily restrict network names.
......................................................................
backend: Temporarily restrict network names.
Long network names feature isn't ready for 4.1.5 as several bugs and
questions still remain open. As a protective measure, restrict network
names to 15 ASCII characters but keep all background logic related to
vdsm_name; once it is deemed ready, revert this patch.
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1479305
Change-Id: Ib3a7bc683b736161ff79eb527799b6c0535e755f
Signed-off-by: Leon Goldberg <lgoldber at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
4 files changed, 28 insertions(+), 17 deletions(-)
Approvals:
Dominik Holler: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Oved Ourfali: Verified
--
To view, visit https://gerrit.ovirt.org/80389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3a7bc683b736161ff79eb527799b6c0535e755f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list