Change in ovirt-engine[master]: core: fixes & simplifications in MoveMacs.java

Code Review gerrit at ovirt.org
Wed Aug 9 07:49:30 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/78132 )

Change subject: core: fixes & simplifications in MoveMacs.java
......................................................................


core: fixes & simplifications in MoveMacs.java

• renamed moveMacsOfUpdatedCluster to
migrateMacsToAnotherMacPoolIfNeeded
• removed duplicate call needToMigrateMacs.
• added missing source-target macPool
comparison in migrateMacsToAnotherMacPool
• added missing requireNonNull in migrateMacsToAnotherMacPool

Bug-Url: https://bugzilla.redhat.com/1435485
Change-Id: Iccad1b2c74280f393afa51d198c990468245533d
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveMacs.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java
3 files changed, 19 insertions(+), 24 deletions(-)

Approvals:
  Martin Mucha: Verified
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/78132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iccad1b2c74280f393afa51d198c990468245533d
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list