Change in ovirt-engine[master]: frontend: Fix new vNIC profile created on the wrong logical ...

Code Review gerrit at ovirt.org
Wed Aug 9 12:40:08 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79747 )

Change subject: frontend: Fix new vNIC profile created on the wrong logical network
......................................................................


frontend: Fix new vNIC profile created on the wrong logical network

Unify network list updates so it's done in the right moment without
overwritting. Add check for set profile if the profile is set we should
disable the network list and set the right network.

Change-Id: I8ba47c886486ac3c4ad42d61244c862139432236
Signed-off-by: Ales Musil <amusil at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1464750
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkProfileListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
4 files changed, 15 insertions(+), 41 deletions(-)

Approvals:
  Ales Musil: Verified
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/79747
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ba47c886486ac3c4ad42d61244c862139432236
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ales Musil <amusil at redhat.com>
Gerrit-Reviewer: Ales Musil <amusil at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list