Change in ovirt-engine[master]: core: undo recent generalization of ovf processing

Code Review gerrit at ovirt.org
Wed Aug 9 17:58:03 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80328 )

Change subject: core: undo recent generalization of ovf processing
......................................................................


core: undo recent generalization of ovf processing

Reverting the attempt to generalize OvfReader and OvfWriter to support
different kinds of OVF implementations. It produces a complicated code
and increases the chance for regressions. A better approach would be
to split the OVF handling of ordinary OVFs in oVirt and general OVFs
that better comply with the specification.

Change-Id: Ibbe176cfc0a5bcb0319d178f573ba948ab1d6fc8
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
2 files changed, 36 insertions(+), 88 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/80328
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbe176cfc0a5bcb0319d178f573ba948ab1d6fc8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list