Change in ovirt-engine[master]: webadmin: quota popup, update the layout

Code Review gerrit at ovirt.org
Fri Aug 11 22:59:13 UTC 2017


>From Greg Sheremeta <gshereme at redhat.com>:

Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80501 )

Change subject: webadmin: quota popup, update the layout
......................................................................


webadmin: quota popup, update the layout

Updated the layout of the new/edit quota popup view. The
all/specific cluster and storage domain radio buttons were
getting cut off in some browsers. Use of horizontal and
vertical panels was reworked to use bootstrap/PatternFly
layouts.

Header inputs are directly in their own Rows since the label
and input have column sizes set. The padding on the label and
input columns had been reduced for a better split vertical form
layout.

Change-Id: I4f6ba1d3e4d22c0bf2590a0749bc4181d34e0084
Signed-off-by: Scott J Dickerson <sdickers at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelRadioButtonEditor.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.ui.xml
3 files changed, 201 insertions(+), 203 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Looks good to me, but someone else must approve
  Scott Dickerson: Verified



-- 
To view, visit https://gerrit.ovirt.org/80501
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f6ba1d3e4d22c0bf2590a0749bc4181d34e0084
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list