Change in ovirt-engine[master]: core: DiskProfileDaoTest to extend BaseGenericDaoTestCase
Code Review
gerrit at ovirt.org
Mon Aug 14 19:46:56 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80436 )
Change subject: core: DiskProfileDaoTest to extend BaseGenericDaoTestCase
......................................................................
core: DiskProfileDaoTest to extend BaseGenericDaoTestCase
Make DiskProfileDaoTest extend BaseGenericDaoTestCase instead of
reimplementing its logic.
Change-Id: I554a5817534dbc9cfcecd5ee7d8532d7c111fd38
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java
1 file changed, 28 insertions(+), 70 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/80436
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I554a5817534dbc9cfcecd5ee7d8532d7c111fd38
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list