Change in ovirt-engine[master]: webadmin: implement sass compression in ovirt brand
Code Review
gerrit at ovirt.org
Thu Aug 17 00:58:07 UTC 2017
>From Greg Sheremeta <gshereme at redhat.com>:
Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80576 )
Change subject: webadmin: implement sass compression in ovirt brand
......................................................................
webadmin: implement sass compression in ovirt brand
* Turn on sass compression in ovirt-brand
* rename the *.css files to .scss, prefix them with '_'.
This changes them to be sass partials, which are then
imported into other main files.
* Created webadmin.scss and welcome.scss, to do the
imports and compilation for those respective applications
into webadmin.css and welcome.css
* Change ovirt-brand to now use webadmin.css and welcome.css,
which are now the compiled output from sass.
Change-Id: I5b3f576b9348c08d5324fc53adce1d51676393c6
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/brands/ovirt-brand/pom.xml
M frontend/brands/ovirt-brand/src/main/resources/branding.properties
R frontend/brands/ovirt-brand/src/main/sass/_branding_common.scss
R frontend/brands/ovirt-brand/src/main/sass/_branding_webadmin.scss
R frontend/brands/ovirt-brand/src/main/sass/_ovirt-patternfly-compat.scss
R frontend/brands/ovirt-brand/src/main/sass/_ovirt.scss
R frontend/brands/ovirt-brand/src/main/sass/_patternfly-ovirt-overrides.scss
R frontend/brands/ovirt-brand/src/main/sass/_webadmin_legacy.scss
R frontend/brands/ovirt-brand/src/main/sass/_welcome_base.scss
A frontend/brands/ovirt-brand/src/main/sass/webadmin.scss
A frontend/brands/ovirt-brand/src/main/sass/welcome.scss
11 files changed, 26 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80576
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b3f576b9348c08d5324fc53adce1d51676393c6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list